feat: sim item filters by best valid #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
force-pushed
the
prestwich/best-valid
branch
from
018c868 to
2c2eb0d
Compare
Evalir
reviewed
Jan 7, 2026
prestwich
force-pushed
the
prestwich/decode-before-drive
branch
from
a8944d4 to
4818f22
Compare
prestwich
force-pushed
the
prestwich/best-valid
branch
from
cdaa8aa to
ac4331c
Compare
prestwich
force-pushed
the
prestwich/decode-before-drive
branch
from
4818f22 to
dc448ae
Compare
prestwich
force-pushed
the
prestwich/best-valid
branch
from
ac4331c to
35e8391
Compare
prestwich
changed the base branch from
prestwich/decode-before-drive
to
graphite-base/161
prestwich
force-pushed
the
prestwich/best-valid
branch
from
8b53d65 to
ad9a677
Compare
prestwich
force-pushed
the
graphite-base/161
branch
from
dc448ae to
4c8148a
Compare
Evalir
reviewed
Jan 8, 2026
Evalir
reviewed
Jan 8, 2026
prestwich
force-pushed
the
prestwich/best-valid
branch
from
768f737 to
236cf11
Compare
Evalir
reviewed
Jan 15, 2026
Comment on lines
+161
to
+162
| // Peek to perform the balance check for the first tx | ||
| if let Some(first) = items.peek() { |
Member
There was a problem hiding this comment.
this only checks the first transaction. if the bundle contains multiple senders, shouldn't we check the first tx balance for each?
Member
There was a problem hiding this comment.
I had already read it. I wanted stricter validation here, but I see how making it more strict can discard valid bundles
Member
Author
There was a problem hiding this comment.
// We do not check balances after
// the first tx, as they may have changed due to prior txs in the
// bundle.
is there a way we can rewrite this to be more clear?
Evalir
approved these changes
Jan 16, 2026
Comment on lines
+161
to
+162
| // Peek to perform the balance check for the first tx | ||
| if let Some(first) = items.peek() { |
Member
There was a problem hiding this comment.
I had already read it. I wanted stricter validation here, but I see how making it more strict can discard valid bundles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimCache now exposes methods to filter items by the best VALID transaction